-
Notifications
You must be signed in to change notification settings - Fork 2k
docs: Update Node.js to v22 and usage examples in README.md #2243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm also thinking about updating docker compose example too. Is it OK to do it in this PR? services:
node:
image: "node:22"
environment:
- NODE_ENV=production
volumes:
- ./:/home/node/app
ports: # use if it is necessary to expose the container to the host machine
- "8081:8081"
command: ["npm", "start"] |
Yes please 🙂 |
84f117e
to
d9df67d
Compare
@coderabbitai, could you provide a better PR subject and description? |
Summary from GitHub Copilot:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also include any related changes in the PR title and description, not just the Node.js version. Thank you.
Hi @PeterDaveHello I updated the title and description. Sorry for the untested changes like deleting |
@mertssmnoglu no problem, just let me know when it's ready. |
It's ready right now. |
3596da2
to
6a4c313
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the Node.js documentation to use version 22 (LTS) instead of older versions and modernizes Docker Compose syntax to follow current best practices.
- Updated Node.js version references from v8/v16 to v22 across all examples
- Modernized Docker Compose configuration by removing deprecated version field and improving syntax
- Aligned port configurations between Dockerfile and Docker Compose examples for consistency
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Updates the documentation to use version 22 (LTS) instead of older versions, and modernizes Docker Compose syntax: - Bump all Node.js version references to 22 - Align ports and commands in Docker Compose example for consistency - Remove deprecated fields from Docker Compose example This keeps documentation up to date and reduces confusion for users. Signed-off-by: Mert Şişmanoğlu <[email protected]>
6a4c313
to
ff7503f
Compare
Update examples to Node.js 22(LTS) and modernize Docker Compose syntax.
Description
Node.js Version
node:8
andnode:16
image tags tonode:22
in README.Docker Compose
command
to array syntax for clarity.expose
field for simplicity.Motivation and Context
As a developer, I would like to see latest LTS version in the documentation with the up to date Docker Compose example.
Types of changes
Checklist