Skip to content

Conversation

avivkeller
Copy link
Member

Fast-tracking.

Ref: nodejs/nodejs.org#8106 (comment)

@avivkeller avivkeller requested a review from a team as a code owner October 10, 2025 21:27
@Copilot Copilot AI review requested due to automatic review settings October 10, 2025 21:27
@avivkeller avivkeller added the fast track This PR can land before the typical review time, with a :+1: from collaborators label Oct 10, 2025
Copy link

vercel bot commented Oct 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
api-docs-tooling Ready Ready Preview Oct 10, 2025 9:29pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the prepare npm script to prevent build failures when husky is not available or fails to initialize. The change adds error handling to the husky command by using || exit 0 to ensure the script always exits successfully.

  • Modified the prepare script to gracefully handle husky failures

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.55%. Comparing base (a7f0f57) to head (191bbf1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #452   +/-   ##
=======================================
  Coverage   74.55%   74.55%           
=======================================
  Files         107      107           
  Lines       10453    10453           
  Branches      681      681           
=======================================
  Hits         7793     7793           
  Misses       2658     2658           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with this change in principle, but very concerned why a consumer of this package would be running into this in the first place.

@avivkeller
Copy link
Member Author

Fine with this change in principle, but very concerned why a consumer of this package would be running into this in the first place.

If it's used as a git dependency, lifecycle scripts are ran.

@MattIPv4
Copy link
Member

Hm okay, that concerns me, esp. given having looked at the logs, it's doing npm install rather than npm ci?

@avivkeller
Copy link
Member Author

avivkeller commented Oct 10, 2025

Hm okay, that concerns me, esp. given having looked at the logs, it's doing npm install rather than npm ci?

Indeed it does (at least for pnpm), https://github.com/pnpm/pnpm/blob/main/exec/prepare-package/src/index.ts#L45

@avivkeller avivkeller merged commit b2da320 into main Oct 10, 2025
19 checks passed
@avivkeller avivkeller deleted the husky-fixup branch October 10, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast track This PR can land before the typical review time, with a :+1: from collaborators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants