Skip to content

Conversation

avivkeller
Copy link
Member

This PR bumps ui-components to include the responsive tables.

Additionally, it bumps all dependencies and adds "eslint-import-resolver-node", since my local linting wasn't working without it, however, I can revert that if linting is unaffected in CI.

The downside to this is that sub-tables have very little space, shown below:

image

@avivkeller avivkeller requested a review from a team as a code owner September 20, 2025 17:20
@Copilot Copilot AI review requested due to automatic review settings September 20, 2025 17:20
Copy link

vercel bot commented Sep 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
api-docs-tooling Ready Ready Preview Sep 20, 2025 5:21pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds responsive table functionality by bumping the UI components library and updating dependencies. The main change involves adding data attributes to table cells for mobile responsiveness.

  • Upgraded @node-core/ui-components from 1.1.0 to 1.2.0 to include responsive table features
  • Enhanced table transformation to add responsive data attributes for mobile displays
  • Updated all dependencies to their latest versions

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/generators/jsx-ast/utils/transformer.mjs Added logic to extract table headers and apply data-label attributes to table cells for responsive behavior
package.json Updated dependencies including UI components library and added eslint-import-resolver-node

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Sep 20, 2025

Codecov Report

❌ Patch coverage is 3.70370% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.56%. Comparing base (4c6ffae) to head (3cc3a16).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/generators/jsx-ast/utils/transformer.mjs 3.70% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
- Coverage   74.69%   74.56%   -0.13%     
==========================================
  Files         107      107              
  Lines       10440    10459      +19     
  Branches      681      681              
==========================================
+ Hits         7798     7799       +1     
- Misses       2640     2658      +18     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants