-
Notifications
You must be signed in to change notification settings - Fork 17
feat(css): responsive tables #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds responsive table functionality by bumping the UI components library and updating dependencies. The main change involves adding data attributes to table cells for mobile responsiveness.
- Upgraded
@node-core/ui-components
from 1.1.0 to 1.2.0 to include responsive table features - Enhanced table transformation to add responsive data attributes for mobile displays
- Updated all dependencies to their latest versions
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
src/generators/jsx-ast/utils/transformer.mjs | Added logic to extract table headers and apply data-label attributes to table cells for responsive behavior |
package.json | Updated dependencies including UI components library and added eslint-import-resolver-node |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #440 +/- ##
==========================================
- Coverage 74.69% 74.56% -0.13%
==========================================
Files 107 107
Lines 10440 10459 +19
Branches 681 681
==========================================
+ Hits 7798 7799 +1
- Misses 2640 2658 +18
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
This PR bumps ui-components to include the responsive tables.
Additionally, it bumps all dependencies and adds
"eslint-import-resolver-node"
, since my local linting wasn't working without it, however, I can revert that if linting is unaffected in CI.The downside to this is that sub-tables have very little space, shown below: