-
-
Notifications
You must be signed in to change notification settings - Fork 44
fix(search): use advanced search #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the GitHub agenda issues functionality to use GitHub's advanced search API instead of iterating through all organization repositories individually. This change improves performance by making a single search query instead of multiple repository-specific queries.
- Switched from repository iteration to GitHub search API with
advanced_search: true
- Updated data structure from array of repo objects to a key-value object mapping
- Removed unused parameters and simplified function signatures
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/github.mjs | Replaces repository iteration with GitHub search API and updates return type |
src/meeting.mjs | Updates function signature and data processing to handle new object structure |
src/constants.mjs | Adds constant for repository URL prefix length used in URL parsing |
create-node-meeting-artifacts.mjs | Removes unused meetingConfig parameter from function call |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Bump @ovflowd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM, but would love to have my comments replied at least :)
cc @ovflowd - This PR reduces the amount of times the GH API is called significantly by using advanced search