aix: add AIX7.1 build machines to CI

[sam-github]

Plan is a gradual addion of AIX7.1 to test configs, and then an even more gradual switch over of the release builds from AIX6.1 to AIX7.1.

See this for details:

• Enable jenkins testing on AIX71 #2098 (comment)

This is a tracking issue, to reference from pull requests, and to comment on as changeover occurs, if problems occur, or to notify interested people what is happening.

[sam-github]

I added aix-7.1 to the build labels for https://ci.nodejs.org/job/node-test-commit-aix/

Building:

• 14.x: https://ci.nodejs.org/job/node-test-commit-aix/27417/ (should build on 7.1)
• 12.x: https://ci.nodejs.org/job/node-test-commit-aix/27418/ (should not build on 7.1 for the moment)

[richardlau]

I added aix-7.1 to the build labels for https://ci.nodejs.org/job/node-test-commit-aix/

Building:

* 14.x: https://ci.nodejs.org/job/node-test-commit-aix/27417/ (should build on 7.1)

* 12.x: https://ci.nodejs.org/job/node-test-commit-aix/27418/ (should not build on 7.1 for the moment)

aix71-ppc64 would follow the existing labelling convention.

[sam-github]

@richardlau Am I greatly misunderstanding the groovy setup?

build/jenkins/scripts/VersionSelectorScript.groovy

Line 64 in 48e9917

[ /aix71/, anyType, lt(14) ],

looks to me like it excludes aix7.1 for lt 14, but its running:

13:07:51 Commit message: "Working on v12.14.1"
...
13:07:56 Triggering node-test-commit-aix » aix61-ppc64
13:07:56 Triggering node-test-commit-aix » aix-7.1

• https://ci.nodejs.org/job/node-test-commit-aix/27418/console

... And I think I see the problem, I selected build label aix-7.1, but the groovy script needs to apply to aix71-ppc64...

I changed the build label selected for the job.

[richardlau]

@sam-github I think the job isn't using the VersionSelectorScript -- most likely because previously we haven't had to exclude anything on AIX before.

[sam-github]

I'll go check... but I think it worked this last time:

• 13.x: https://ci.nodejs.org/job/node-test-commit-aix/27420/
• 10.x: https://ci.nodejs.org/job/node-test-commit-aix/27421/

Also, there used to be exclusions, < 6 didn't support AIX:

[ /aix61/, anyType, lt(6) ],

I'll go look at the jobs, try and figure out where the goovy comes in.

[sam-github]

Unsurprisingly, you are absolutely correct wrt. ci.nodejs.org.

The script is used for https://ci-release.nodejs.org/job/iojs+release/configure, probably because it is only over there that release exclusions take place.

[sam-github]

I used https://ci.nodejs.org/job/node-test-commit-smartos/configure as the example, see above, and added that stanza to the aix build. I'll kick off some more builds when the current ones are done to see if it worked.

[richardlau]

Looks like tap2junit can't be found.

e,g, https://ci.nodejs.org/job/node-test-commit-aix/27420/nodes=aix71-ppc64/console

17:30:27 [aix71-ppc64] $ /bin/sh -xe /tmp/jenkins5116011305803213197.sh
17:30:27 + mkdir out/junit
17:30:27 mkdir: 0653-358 Cannot create out/junit.
17:30:27 out/junit: Do not specify an existing file.
17:30:27 + true
17:30:27 + tap2junit -i test.tap -o out/junit/test.xml
17:30:27 /tmp/jenkins5116011305803213197.sh[5]: tap2junit:  not found.
17:30:28 POST BUILD TASK : FAILURE

[sam-github]

Path problem of some sort:

% ssh  test-ibm-aix71-ppc64_be-1 /opt/freeware/bin/tap2junit -V
usage: tap2junit [-h] --input INPUT --output OUTPUT
tap2junit: error: argument --input/-i is required

Interesting the build still passed.

10.x: https://ci.nodejs.org/job/node-test-commit-aix/27421/nodes=aix71-ppc64/console failed, looks like a timeout.

I'll find where the path is supposed to be set.

[richardlau]

Interesting the build still passed.

Probably because the tests passed and we don't have the following checked in the post build steps:

One could argue that the build passing is accurate (the tests did pass but our post build tap->junit conversion failed).

[sam-github]

I modified the post-build step pictured above to include /opt/freeware/bin, that shouldn't affect any of the compilation stages, where PATH is sometimes used to search for compilers.

#/bin/bash -x +e
export PATH=/opt/freeware/bin:$PATH
mkdir out/junit || true
tap2junit -i test.tap -o out/junit/test.xml
tap2junit -i cctest.tap -o out/junit/cctest.xml || true
rm -Rf out/Release/obj.target

[sam-github]

Also, the VersionSelector.groovy depends on a plugin to export node versions as env vars, I enabled it, the "Extract Node.js versions as parameters" section is new:

[sam-github]

^-- FTR, @richardlau found that.

Now, groovy is respected: https://ci.nodejs.org/job/node-test-commit-aix/27423/console is a 10.x branch build, and its only on AIX6.1.

https://ci.nodejs.org/job/node-test-commit-aix/27424/ is a master/14.x build, it was run on AIX7.1 and 6.1, as it should.

https://ci.nodejs.org/job/node-test-commit-aix/27425/console is a 13.x build, it ran, correctly, only on 6.1 (and then I cancelled it)

So that's good, we can now control versions via the groove script.

[richardlau]

^-- FTR, @richardlau found that.

Also FTR the plugin source is https://github.com/nodejs/node-version-jenkins-plugin.

Technically VersionSelectorScript.groovy doesn't explicitly depend on that plugin... it expects NODEJS_MAJOR_VERSION to be set and the plugin does that based on the Git checkout (there are other jobs that use the groovy script without that plugin by setting NODEJS_MAJOR_VERSION as an explicit build parameter).

build/jenkins/scripts/VersionSelectorScript.groovy

Lines 108 to 109 in 48e9917

	if (parameters['NODEJS_MAJOR_VERSION'])
	nodeMajorVersion = parameters['NODEJS_MAJOR_VERSION'].toString().toInteger()