windows 10, nodejs 10.12.0 boxstarter dependency force reboot

[danjo133]

When installing nodejs 10.12.0 from https://nodejs.org/dist/v10.12.0/node-v10.12.0-x64.msi the installer asks if the user wants to install some additional dependencies for nodejs modules containing c++-code.

This installs Boxstarter/Chocolatery which, out of the blue, force rebooted my computer with no warning, no option to save files or anything else. For me, it rebooted 4 times during install.

This is acceptable precisely never.

[vsemozhetbyt]

cc @nodejs/platform-windows and @joaocgreis @tniessen as per possibly related PRs:

nodejs/node#22645
nodejs/node#23003
nodejs/node#22988

[joaocgreis]

Rebooting is essential to install those tools reliably. @danjo133 the fact that your machine rebooted 4 times is a strong indication that the installation would have failed if not allowed to reboot.

The script warns about this:

[XieJiSS]

Well it did warn, but I believe it's not noticeable enough, for many users simply press Enter or whatever when they see Press any key to continue....
Would it be possible to change the prompt from Press any key to continue... into Have you saved all your files and closed all open programs? (y/N)?

[tdaniely]

This retarded script that breaks all MSI practices because you're too lazy to properly integrate the depdendency installations. Installed 50 different things, that all of them from the VS to the build tools and the c++ redist, and the 20 windows KBs and everything else were already installed and updated. To do this it restarted my workstation twice, installed chocolatey which I don't need, Installed "Boxstarter" The non rebooting installer that reboots all the time. And all of this in a stupid console windows that obviously no user will ever ever read. And all of this in an installation of NodeJS the most PORTABLE platform in existence that has no dependencies. Thanks kids who think they know shit.

[refack]

Hello @tdaniely please edit your comment, to tone it down, and be compliant with the CoC
זה לא לעניין, אנשים עובדים קשה על זה, לפעמים עושים טעויות.