Replace deleted elements at addition #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyashuni
changed the title
yurymalkov
reviewed
Nov 8, 2022
dyashuni
force-pushed
the
replace_deleted
branch
from
5503715 to
7023e13
Compare
dyashuni
force-pushed
the
replace_deleted
branch
from
7023e13 to
22cdb46
Compare
dyashuni
force-pushed
the
replace_deleted
branch
from
7db5671 to
ef7e383
Compare
yurymalkov
requested changes
Nov 28, 2022
|
|
||
| size_t max_elements_{0}; | ||
| size_t cur_element_count{0}; | ||
| mutable std::atomic<size_t> cur_element_count{0}; // current number of elements |
There was a problem hiding this comment.
Why is it atomic, shouldn't it be locked all the times by external locks?
yurymalkov
reviewed
Dec 17, 2022
yurymalkov
reviewed
Jan 8, 2023
yurymalkov
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new method to replace a deleted element when a new one is added:
labeltype addPointToVacantPlace(const void* data_point, labeltype label)The method is the same as
addPointbut allows to replace a deleted element with a new one to save memory. Note: addPointToVacantPlace is much slower than addPoint, because replacement is a heavy operation.Edit: