Skip to content

Encode branch name #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Encode branch name #248

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c04a309
Add URL-encoding when submitting a branch name for deletion
YannGallice Sep 7, 2022
09a49d3
Add URL-encoding when submitting a branch name for deletion
YannGallice Sep 7, 2022
4f3abe9
Merge branch 'encode-branch-name' of https://github.com/YannGA/GitLab…
YannGallice Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/GitLabApiClient/BranchClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using GitLabApiClient.Internal.Http;
using GitLabApiClient.Internal.Paths;
using GitLabApiClient.Internal.Queries;
using GitLabApiClient.Internal.Utilities;
using GitLabApiClient.Models.Branches.Requests;
using GitLabApiClient.Models.Branches.Responses;
using GitLabApiClient.Models.Projects.Responses;
Expand Down Expand Up @@ -62,7 +63,7 @@ public async Task<Branch> CreateAsync(ProjectId projectId, CreateBranchRequest r
/// <param name="projectId">The ID, path or <see cref="Project"/> of the project.</param>
/// <param name="branchName">The branch, you want deleted.</param>
public async Task DeleteBranch(ProjectId projectId, string branchName) =>
await _httpFacade.Delete($"projects/{projectId}/repository/branches/{branchName}");
await _httpFacade.Delete($"projects/{projectId}/repository/branches/{branchName.UrlEncode()}");

/// <summary>
/// Deletes the merged branches
Expand Down