feat(grma): generalize to k loci + compact tree storage #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR delivers four changes:
xy:wz
), while keeping the genotype representation compact.What changed
(1) GVH/HVG and mismatches
For each locus, patient/donor alleles are handled as sets (no duplicates).
We now compute sizes (cardinalities):
GVH := | Patient \ Donor |
HVG := | Donor \ Patient |
The number of mismatches is
max(GVH, HVG)
.File:
grma/match/donors_matching.py
.(2) Missing donor in candidates
cpdef tuple neighbors_2nd(self, UINT node)
, a duplicate-1
placeholder was present; removing the extra one prevents dropping a donor from the results.File:
grma/match/lol_graph.pyx
.(3) k-loci generalization
DRB3/4/5
,DRBX
last locus, etc.).(4) Additional allele formats + compact storage
xy:wz
(varying digit widths/fields).bidict
).hash
keys for compact indices; any hash collisions are harmless since exact mismatch checks operate on the UID layer.Affected: many files (tree maintenance, matching, LOL/SLUG building, utilities).
New dependency:
bidict
.