Update testWithSpectron to testWithPlaywright #1650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the 3.0.0-alpha.3 release the entire if statement was commented out. That resulted in the mocha test not running. By uncommenting the code and updating it to PlayWright I got my mocha tests running.
|
@nklayman Could you take a look at this? |
|
@nklayman friendly ping ;) |
|
Sorry for ignoring this for so long, been swamped with school and work. My spring break is next week and I think I'll have time to review this then. |
|
@nklayman friendly ping ;) |
|
Although I suggested to use the WebDriver interface (#1628 (comment)). This should be merged in the V3 branch for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 3.0.0-alpha.3 release the entire if statement was commented out. That resulted in the mocha test not running. By uncommenting the code and updating it to PlayWright I got my mocha tests running.
I can't find the code being commented out on the v3 branch, but please make sure it isn't commented out.