Skip to content

Allow memfd_create to be used with older glibc (<2.27) #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow memfd_create to be used with older glibc (<2.27) #2146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelog/2146.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fixed `memfd_create` to not depend on glibc version being greater than 2.27.
([#2146](https://github.com/nix-rust/nix/pull/2146))
7 changes: 5 additions & 2 deletions src/sys/memfd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,12 @@ pub fn memfd_create(name: &CStr, flags: MemFdCreateFlag) -> Result<OwnedFd> {
// Android does not have a memfd_create symbol
not(target_os = "android"),
any(
// Note that memfd_create is available since release 13.0
// See https://man.freebsd.org/cgi/man.cgi?query=memfd_create
target_os = "freebsd",
// If the OS is Linux, gnu and musl expose a memfd_create symbol but not uclibc
target_env = "gnu",
// If the OS is Linux, gnu and musl expose a memfd_create symbol but not uclibc.
// But in glibc it is availible since 2.27. The oldest one officially supported by Rust is 2.17.
// So it is reasonable to keep compatibility with it.
target_env = "musl",
)))]
{
Expand Down