Fix nix-community/disko#1045 #1058
Open
+261
−231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please don’t change the Nixpkgs input to your own fork, you’ll need to wait till it gets merged upstream |
|
That PR got merged 🎉 |
Member
|
https://nixpkgs-tracker.ocfox.me/?pr=414391 Currently only on master, not nixpkgs-unstable yet |
|
It's in every channel now 🎉 |
Member
|
@nothingnesses can you rebase this PR? |
nothingnesses
force-pushed
the
nix-community/disko#1045
branch
3 times, most recently
from
1f07dfb to
6fe546d
Compare
nothingnesses
force-pushed
the
nix-community/disko#1045
branch
from
6fe546d to
d6d6c38
Compare
nothingnesses
commented
Nov 21, 2025
tests/bcachefs.nix
Outdated
Comment on lines
22
to
28
| extraModulePackages = [ | ||
| (config.boot.kernelPackages.callPackage pkgs.bcachefs-tools.kernelModule {}) | ||
| ]; | ||
| # Can also use the following instead of the above, | ||
| # which doesn't necessitate passing in `config`, | ||
| # so `{ config, ... }: ` can be removed: | ||
| # supportedFilesystems = [ "bcachefs" ]; |
Contributor
Author
Contributor
Author
|
Looks like the disko-install test failed when it timed out trying to download this patch. Can someone restart it please? |
Member
|
I ran it again but it's failing to download the patch inside the VM test which means there's a dependency missing from: disko/tests/disko-install/default.nix Lines 9 to 19 in 163dbfb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1045 and updates the bcachefs test to handle the changes made. It also replaces
nixpkgswith a version from this PR. This part will need to be reverted, once the changes from that version gets merged upstream.