Skip to content

FIX: VRML typo (VMRL) in MeshFix #2757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2018
Merged

FIX: VRML typo (VMRL) in MeshFix #2757

merged 1 commit into from
Oct 25, 2018

Conversation

effigies
Copy link
Member

Summary

VRML is a format, VMRL doesn't seem to be, so it looks like the opposite of the problem I thought we had in #2755.

@MartinGrignard can you pull this branch and verify that it resolves your issue?

Fixes #2755.

List of changes proposed in this PR (pull-request)

  • Change save_as_vmrl to save_as_vrml

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@effigies effigies added this to the 1.1.4 milestone Oct 25, 2018
@MartinGrignard
Copy link
Contributor

It did work! Great thanks for your quick work!

@effigies effigies merged commit 0c009ff into nipy:master Oct 25, 2018
@effigies effigies deleted the fix/meshfix_typo branch October 25, 2018 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.4
Development

Successfully merging this pull request may close these issues.

'MeshFixInputSpec' object has no attribute 'save_as_vrml'
2 participants
@effigies @MartinGrignard