BF: fix recursion error on Python 3.3 #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.3 seems to get upset with filling format string values from byte strings. See: http://nipy.bic.berkeley.edu/builders/nibabel-py3.3/builds/240/steps/shell_5/logs/stdio
Current coverage is 94.23% (diff: 100%)@@ master #472 diff @@
==========================================
Files 160 160
Lines 21197 21198 +1
Methods 0 0
Messages 0 0
Branches 2266 2267 +1
==========================================
+ Hits 19975 19976 +1
Misses 802 802
Partials 420 420
|
|
LGTM (I'm curious what is the recursion limit for Python on that machine?) |
|
Not sure on the recursion limit, but I think this will leads to infinite recursion, because the format string is failing and then it tries to make an error trace that calls the |
|
Gotcha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.3 seems to get upset with filling format string values from
byte strings. See:
http://nipy.bic.berkeley.edu/builders/nibabel-py3.3/builds/240/steps/shell_5/logs/stdio
Fixed by this change - see
try_branch.pyrun at:http://nipy.bic.berkeley.edu/builders/nibabel-py3.3/builds/248/steps/shell_5/logs/stdio