Skip to content

RF: change absolute to relative imports #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2014

Conversation

matthew-brett
Copy link
Member

Use relative imports for nibabel modules.

@larsoner
Copy link
Contributor

using git grep "from nibabel" I see some remaining in nibabel/freesurfer/mghformat.py

@larsoner
Copy link
Contributor

...and nibabel/tests/data/check_parrec_reslice.py

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) when pulling fb8c99d on matthew-brett:to-relative-imports into 5c15ed8 on nipy:master.

@matthew-brett
Copy link
Member Author

Yep - the freesurfer ones are the ones removed in the PR just merged, I'll rebase and hope they go away. 'check_parrec_reslice.py' is a script, that I used to reslice the PARREC files together to check registration, so it's meant to be run from any-old-where, and not imported as code, so I had left those.

Use relative imports for nibabel modules.
@larsoner
Copy link
Contributor

Ahh, cool -- LGTM

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0%) when pulling 2717eca on matthew-brett:to-relative-imports into cc93272 on nipy:master.

matthew-brett added a commit that referenced this pull request Nov 12, 2014
MRG: change absolute to relative imports

Use relative imports for nibabel modules.
@matthew-brett matthew-brett merged commit 6f507aa into nipy:master Nov 12, 2014
@matthew-brett matthew-brett deleted the to-relative-imports branch November 12, 2014 20:09
grlee77 pushed a commit to grlee77/nibabel that referenced this pull request Mar 15, 2016
MRG: change absolute to relative imports

Use relative imports for nibabel modules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants