FIX: Minor fixes to clean up tests in windows #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review/merge from my end. I think my problems running scripts might be due to the fact that I run them in windows from a Git bash terminal as opposed to an actual Windows shell. I'll leave fixing that to a separate PR at some point. |
|
Looks good to me, I'll merge and rebase my PR on top of this. |
matthew-brett
added a commit
that referenced
this pull request
Oct 24, 2014
MRG: Minor fixes to clean up tests in windows Various PEP8 changes and context manager suppression of warnings.
|
Decided to start with the simple and boring PR, I see :) |
|
:) - it takes time for me to warm up in the morning. |
grlee77
pushed a commit
to grlee77/nibabel
that referenced
this pull request
Mar 15, 2016
MRG: Minor fixes to clean up tests in windows Various PEP8 changes and context manager suppression of warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some minor tweaks I wanted to have in place when coding in Windows on Python3. I have an issue running the scripts, but that one will be harder to fix.