Skip to content

DOC: Update documentation for InTemporaryDirectory to mark it as not thread-safe #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jacobdr
Copy link
Contributor

@jacobdr jacobdr commented May 7, 2022

Closes #1102

@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #1103 (420164a) into master (7cfaebf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1103   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files         100      100           
  Lines       12247    12247           
  Branches     2393     2393           
=======================================
  Hits        11303    11303           
  Misses        621      621           
  Partials      323      323           
Impacted Files Coverage Δ
nibabel/tmpdirs.py 92.10% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cfaebf...420164a. Read the comment docs.

@matthew-brett
Copy link
Member

Thanks - looks fine.

@matthew-brett matthew-brett merged commit 9fbddef into nipy:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thread safety concerns with reliance on nibabel.tmpdirs.InTemporaryDirectory
2 participants