When a compilation error occurs, fail any of the tests that are based on... #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on that compilation.
nikhilk
added a commit
that referenced
this pull request
Jun 23, 2013
When a compilation error occurs, fail any of the tests that are based on...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... that compilation.
If you make a change to the compiler that breaks compilation of a test case, and then run tests that are based on the result of compiled code, the compilation fails quietly and leaves the previously compiled result alone. As a result there's a false negative.
This change records which scripts fail to compile, and any tests that are based on that compilation will fail before being run.