Avoid duplicating warning in ng-repeat #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add "'~' + $index" in the following line: <li ng-repeat = "row in tree_rows | filter...track by row.branch.uid || '~' + $index"> When row.branch.uid is empty, ng-repeat error will occur: "Duplicates in a repeater are not allowed". 2. Fix the variables of the example in README. 3. Add repository and fix license in package.json.
|
uid should never be empty so I'm not sure if this change is necessary; however, the other cleanup items are still valid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add " '~' + $index" in the following line:
<li ng-repeat = "row in tree_rows | filter...track by row.branch.uid || '~' + $index">When row.branch.uid is empty, ng-repeat error will occur: "Duplicates in a repeater are not allowed".
Fix the variables of the example in README.
<abn-tree tree-data = "my_treedata" ...>Add repository and fix license in package.son (
licence->license).