Skip to content

Conversation

@batzuu
Copy link
Contributor

@batzuu batzuu commented Nov 14, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

This PR is in the continuation of PR: Fixing size parameter handling and aims to add unit test for gRPC and session for the new nifake function added in the earlier PR.

  • Adds necessary changes to enable gRPC calls for the new test method MultipleArraysDifferentSize in nifake.proto.
  • Adds corresponding generated files, and tests (covered in testing section).

List issues fixed by this Pull Request

Adds to the validation for changes added to fix Issue 2137: Fix size parameter handling for functions with parameters referencing multiple size parameters.

What testing has been done?

  • Unit test test_multiple_arrays_different_size added in nifake's test_grpc.py and test_session.py for validation.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.59%. Comparing base (cf435c0) to head (4b6fe22).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2140      +/-   ##
==========================================
- Coverage   89.62%   89.59%   -0.04%     
==========================================
  Files          61       48      -13     
  Lines       17308    16051    -1257     
==========================================
- Hits        15513    14381    -1132     
+ Misses       1795     1670     -125     
Flag Coverage Δ
nidcpowersystemtests 94.65% <ø> (+0.04%) ⬆️
nidcpowerunittests ?
nidigitalsystemtests 92.26% <ø> (ø)
nidigitalunittests ?
nidmmsystemtests 92.72% <ø> (ø)
nifakeunittests ?
nifgensystemtests 94.61% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests ?
nirfsgsystemtests 76.53% <ø> (ø)
niscopesystemtests 92.94% <ø> (ø)
niscopeunittests ?
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf435c0...4b6fe22. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants