Skip to content

Conversation

@ni-jfitzger
Copy link
Collaborator

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

Our CHANGELOG incorrectly stated that we added Python 3.8 support in both 1.1.4 and 1.2.0. In 1.2.0, we added the classifier to declare support on the PyPI page, because we neglected to do so in 1.1.4.

This change clarifies the 1.2.0 section of the CHANGELOG.

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

PR Checks

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.35%. Comparing base (dd57eae) to head (fff98e8).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (dd57eae) and HEAD (fff98e8). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (dd57eae) HEAD (fff98e8)
niscopeunittests 4 3
nisesystemtests 1 0
niswitchsystemtests 1 0
nimodinstsystemtests 1 0
nidmmsystemtests 1 0
niscopesystemtests 1 0
nifgensystemtests 1 0
nidcpowersystemtests 1 0
nitclksystemtests 1 0
nidigitalsystemtests 1 0
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2074      +/-   ##
==========================================
- Coverage   91.33%   82.35%   -8.99%     
==========================================
  Files          66       28      -38     
  Lines       16274     4001   -12273     
==========================================
- Hits        14864     3295   -11569     
+ Misses       1410      706     -704     
Flag Coverage Δ
codegenunittests 84.95% <ø> (ø)
nidcpowersystemtests ?
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests ?
nidigitalunittests 68.45% <ø> (ø)
nidmmsystemtests ?
nifakeunittests 87.24% <ø> (ø)
nifgensystemtests ?
nimodinstsystemtests ?
nimodinstunittests 94.20% <ø> (ø)
niscopesystemtests ?
niscopeunittests 43.20% <ø> (ø)
nisesystemtests ?
niswitchsystemtests ?
nitclksystemtests ?
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 42 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd57eae...fff98e8. Read the comment docs.

@ni-jfitzger
Copy link
Collaborator Author

Do not merge until after the 1.4.9 release.

Copy link
Collaborator Author

@ni-jfitzger ni-jfitzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CHANGELOG has changed, since this PR was created. I'll need to pull main and recreate the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants