Remove Gateway API types from Configuration-related types in dataplane package #976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e package Problem: Configuration-related types in the data plane package include Gateway API types. As a result: - We need to make any validation-related assumptions about them (ex. certain fields cannot be not nil) in the config package. - It makes it difficult maintain/extend and potentially allow for supporting more routing resource types (outside of Gateway API) in the future. - It makes unit tests more complicated in the config package Solution: - Remove Gateway API types from Configuration-related types. - Move the types to types.go file. - Move converters to convert.go Testing: Unit testing Closes nginx#660
sjberman
approved these changes
Aug 17, 2023
kate-osborn
reviewed
Aug 17, 2023
kate-osborn
approved these changes
Aug 18, 2023
6 tasks
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
…e package (nginx#976) Problem: Configuration-related types in the data plane package include Gateway API types. As a result: - We need to make any validation-related assumptions about them (ex. certain fields cannot be not nil) in the config package. - It makes it difficult maintain/extend and potentially allow for supporting more routing resource types (outside of Gateway API) in the future. - It makes unit tests more complicated in the config package Solution: - Remove Gateway API types from Configuration-related types. - Move the types to types.go file. - Move converters to convert.go Testing: Unit testing Closes nginx#660
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
Configuration-related types in the data plane package include Gateway API types.
As a result:
Solution:
Testing: Unit testing
Closes #660
Checklist
Before creating a PR, run through this checklist and mark each as complete.