Skip to content

Conversation

kate-osborn
Copy link
Contributor

  • Updates the README to include current build and deploy instructions.
  • Adds license, contributing guidelines, code of conduct, pull request template, and the CLA agreement.
  • Makes the registry PREFIX used in make container configurable by user.
  • Adds a README to the cafe example with instructions on how to deploy.

Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kate-osborn
Looks good. Got a few suggestions and comments

@f5yacobucci
Copy link
Contributor

LGTM once comments are resolved.

- Updates the README to include current build and deploy instructions.

- Adds license, contributing guidelines, code of conduct, pull request template, CODEOWNERS, and the CLA agreement.

- Makes the registry PREFIX used in make container configurable by user.

- Adds README to cafe example
@kate-osborn kate-osborn merged commit 72ad354 into nginx:main Mar 30, 2022
@pammecrandall pammecrandall added the enhancement New feature or request label Aug 9, 2022
@lucacome lucacome added documentation Improvements or additions to documentation chore Pull requests for routine tasks and removed enhancement New feature or request labels Aug 19, 2022
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants