Skip to content

Conversation

sjberman
Copy link
Collaborator

Fixed breaking changes relating to these updates:

  • regenerated fakes

  • added status resources to fake client

  • I have read the CONTRIBUTING doc

  • I have added tests that prove my fix is effective or that my feature works

  • I have checked that all unit tests pass after adding my changes

  • I have updated necessary documentation

  • I have rebased my branch onto main

  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Fixed breaking changes relating to these updates:
- regenerated fakes
- added status resources to fake client
@sjberman sjberman requested a review from a team as a code owner May 25, 2023 19:27
@github-actions github-actions bot added chore Pull requests for routine tasks dependencies Pull requests that update a dependency file labels May 25, 2023
Copy link
Contributor

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sjberman sjberman merged commit 888f03b into nginx:main May 25, 2023
@sjberman sjberman deleted the chore/update-deps branch May 25, 2023 21:35
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Fixed breaking changes relating to these updates:
- regenerated fakes
- added status resources to fake client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants