Skip to content

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Oct 7, 2025

Proposed changes

This change adds a new workflow file, openshift-certification.yml which is responsible for validating that our UBI based images of NGF, NGINX OSS, and NGF Operator will pass the RedHad certification process.

This workflow uses RedHat Openshift Preflight tool to pre-certify images before they are published:
https://github.com/redhat-openshift-ecosystem/openshift-preflight

Closes #3909

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.71%. Comparing base (690d123) to head (1ff669b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4035   +/-   ##
=======================================
  Coverage   86.70%   86.71%           
=======================================
  Files         128      128           
  Lines       16758    16758           
  Branches       62       62           
=======================================
+ Hits        14530    14531    +1     
  Misses       2043     2043           
+ Partials      185      184    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shaun-nx shaun-nx marked this pull request as ready for review October 8, 2025 09:47
@shaun-nx shaun-nx requested a review from a team as a code owner October 8, 2025 09:47
Comment on lines 44 to 46
registry: quay.io
username: ${{ secrets.QUAY_USERNAME }}
password: ${{ secrets.QUAY_ROBOT_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we pushing to quay.io? Can't we just run the tool against our images in ghcr?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point... 😅
I think in my mind I was avoiding that as we don't normally push there during PRs, but we will only need to do that while testing this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, NIC push to quay.io: https://quay.io/organization/nginx
I figured that was the way to go about it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to leave it as is right now just while we're testing this.
Once this works I'll remove those and then test with the ghcr images

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ciarams87 the workflow should be using the images from ghcr.io now as well as only running on merges to main and on prod releases

@shaun-nx shaun-nx requested a review from ciarams87 October 9, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

Set up Red Hat container certification testing pipeline
2 participants