Skip to content

Conversation

bjee19
Copy link
Contributor

@bjee19 bjee19 commented Sep 26, 2025

Update Dockerfile alpine packages libexpat and tiff to fix cves.

Verified NGINX Plus image does not contain libexpat or tiff alpine packages, and after these changes, the packages in the built docker image have the updated versions.

@bjee19 bjee19 requested a review from a team as a code owner September 26, 2025 23:52
@github-actions github-actions bot added the chore Pull requests for routine tasks label Sep 26, 2025
@bjee19
Copy link
Contributor Author

bjee19 commented Sep 26, 2025

when running:

docker run --rm \
  --entrypoint /bin/sh \
  nginx-gateway-fabric/nginx:b.jee \
  -c 'apk list --installed'

this is output:

...
libexpat-2.7.2-r0 aarch64 {expat} (MIT) [installed]
...
tiff-4.7.1-r0 aarch64 {tiff} (libtiff) [installed]

showing the correctly updated packages are in the nginx image.

when running:

docker run --rm \
  --entrypoint /bin/sh \
  nginx-gateway-fabric/nginx-plus:b.jee \
  -c 'apk list --installed'

Neither libexpat or tiff are installed. Meaning these packages are not in the nginx plus image and that image is not affected by these cves.

Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.80%. Comparing base (f0b6a3d) to head (a8b114e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3973      +/-   ##
==========================================
- Coverage   86.80%   86.80%   -0.01%     
==========================================
  Files         128      128              
  Lines       16607    16607              
  Branches       62       62              
==========================================
- Hits        14416    14415       -1     
- Misses       2007     2009       +2     
+ Partials      184      183       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjee19 bjee19 enabled auto-merge (squash) September 29, 2025 19:28
@bjee19 bjee19 disabled auto-merge September 29, 2025 20:22
@bjee19
Copy link
Contributor Author

bjee19 commented Sep 29, 2025

Apparently alpine will only keep the latest image for these dependencies https://dl-cdn.alpinelinux.org/alpine/v3.22/main/aarch64/. Meaning we cannot pin the version to 4.7.2-r0 since the dependency won't exist (you can see it doesn't exist, 4.7.3-r0 already came out). Doing a >= will guarantee it will be above the version we need.

@bjee19 bjee19 requested a review from ciarams87 September 29, 2025 20:32
@bjee19 bjee19 enabled auto-merge (squash) September 30, 2025 16:00
@bjee19 bjee19 merged commit 5add16d into main Sep 30, 2025
67 of 68 checks passed
@bjee19 bjee19 deleted the chore/fix-cves branch September 30, 2025 18:21
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Sep 30, 2025
bjee19 added a commit that referenced this pull request Oct 1, 2025
Update Dockerfile alpine packages libexpat and tiff to fix cves.
bjee19 added a commit that referenced this pull request Oct 1, 2025
Cherry-pick #3973. Update Dockerfile alpine packages libexpat and tiff to fix cves.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants