Skip to content

Correct explanatory comment about time #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Correct explanatory comment about time #296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/status/updater_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ var _ = Describe("Updater", func() {
WithScheme(scheme).
Build()

// Rfc3339Copy() removes the monotonic clock reading
// We need to remove it, because updating the status in the FakeClient and then getting the resource back
// involves encoding and decoding the resource to/from JSON, which removes the monotonic clock reading.
// Rfc3339Copy() removes the monotonic clock reading and leaves only second-level precision.
// We use it because updating the status in the FakeClient and then getting the resource back
// involves encoding and decoding the resource to/from JSON, which uses RFC 3339 for metav1.Time.
fakeClockTime = metav1.NewTime(time.Now()).Rfc3339Copy()
fakeClock := &statusfakes.FakeClock{}
fakeClock.NowReturns(fakeClockTime)
Expand Down