-
Notifications
You must be signed in to change notification settings - Fork 139
Closed
Labels
area/gateway/coreRelates to all Core features of GatewayRelates to all Core features of Gatewayarea/gatewayclass/coreRelates to all Core features of GatewayClassRelates to all Core features of GatewayClassarea/httproute/coreRelates to all Core features of HTTPRouteRelates to all Core features of HTTPRoutebugSomething isn't workingSomething isn't workingrefinedRequirements are refined and the issue is ready to be implemented.Requirements are refined and the issue is ready to be implemented.
Milestone
Description
Describe the bug
Webhook Validation is bypassed for existing resources when NKG starts.
Note: the webhook validation running inside NKG process.
To Reproduce
Make sure Webhook is not installed, so that we test the webhook validation running inside NKG process.
- Create a resource that fails webhook validation.
- Deploy NKG
- See that NKG processes the resource.
Why? Because the resource is included in the first batch -- https://github.com/nginxinc/nginx-kubernetes-gateway/blob/13fc9a2428ee90648681abb22e08ef5f79d33e03/internal/events/loop.go#L92
Expected behavior
Validation is not bypassed.
Your environment
- latest main branch
Aha! Link: https://nginx.aha.io/features/NKG-51
Metadata
Metadata
Assignees
Labels
area/gateway/coreRelates to all Core features of GatewayRelates to all Core features of Gatewayarea/gatewayclass/coreRelates to all Core features of GatewayClassRelates to all Core features of GatewayClassarea/httproute/coreRelates to all Core features of HTTPRouteRelates to all Core features of HTTPRoutebugSomething isn't workingSomething isn't workingrefinedRequirements are refined and the issue is ready to be implemented.Requirements are refined and the issue is ready to be implemented.