Skip to content

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented May 14, 2024

Proposed changes

This PR makes staticcheck happy by removing unused var in the telemetry package.

➜  kubernetes-ingress git:(test/fix-staticcheck) ✗ staticcheck ./internal/telemetry/*.go
internal/telemetry/cluster_test.go:921:2: var ingressClassList is unused (U1000)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner May 14, 2024 13:00
@github-actions github-actions bot added the go Pull requests that update Go code label May 14, 2024
@jjngx jjngx merged commit 2613740 into main May 14, 2024
@jjngx jjngx deleted the test/fix-staticcheck branch May 14, 2024 14:14
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants