Skip to content

Unwrap error #3234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2022
Merged

Unwrap error #3234

merged 1 commit into from
Nov 9, 2022

Conversation

@lucacome
Copy link

@lucacome lucacome commented Nov 8, 2022

Unwraps error.

Fixes:

pkg/apis/dos/validation/dos.go:176:70: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)

More info https://go.dev/blog/go1.13-errors

@lucacome lucacome requested a review from a team as a code owner November 8, 2022 23:17
@lucacome lucacome self-assigned this Nov 8, 2022
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 8, 2022
@lucacome lucacome merged commit 492fdb3 into main Nov 9, 2022
@lucacome lucacome deleted the chore/wrap-error branch November 9, 2022 16:31
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
@lucacome @coolbry95
Unwrap error (nginx#3234)
26d6b5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@shaun-nx shaun-nx Awaiting requested review from shaun-nx shaun-nx was automatically assigned from nginxinc/kic

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lucacome lucacome

Labels

chore Pull requests for routine tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lucacome @ciarams87 @jjngx