Add ARCH in Makefile, make Dockerfile more compatible with podman
#3102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
Codecov Report
@@ Coverage Diff @@
## main #3102 +/- ##
=======================================
Coverage 52.39% 52.39%
=======================================
Files 58 58
Lines 15997 15997
=======================================
Hits 8381 8381
Misses 7338 7338
Partials 278 278 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jjngx
approved these changes
Sep 27, 2022
ciarams87
approved these changes
Sep 27, 2022
coolbry95
pushed a commit
to coolbry95/kubernetes-ingress
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ARCHvariable in the Makefile to build for a specific architecture. Defaulting toamd64which is the most popular in k8s at the moment.The
--platformandtype=bindin the Dockerfile, improve compatibility withpodman.