Skip to content

Conversation

@coolbry95
Copy link
Contributor

Proposed changes

In #2839 the RBAC was changed to add the coordination.k8s.io/leases for the deployments/rbac but not for deployments/helm-chart/templates/rbac. Without this change the helm chart deployment is broken on main.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Copy link

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @coolbry95 good catch!

@lucacome lucacome self-assigned this Sep 26, 2022
@lucacome lucacome requested review from a team, haywoodsh, jjngx and shaun-nx September 26, 2022 23:36
@lucacome lucacome added this to the v2.4.0 milestone Sep 27, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3101 (096d136) into main (7a3533b) will not change coverage.
The diff coverage is n/a.

❗ Current head 096d136 differs from pull request most recent head 7ca690e. Consider uploading reports for the commit 7ca690e to get more accurate results

@@           Coverage Diff           @@
##             main    #3101   +/-   ##
=======================================
  Coverage   52.23%   52.23%           
=======================================
  Files          58       58           
  Lines       16045    16045           
=======================================
  Hits         8381     8381           
  Misses       7386     7386           
  Partials      278      278           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ciarams87 ciarams87 merged commit 1bc5233 into nginx:main Sep 27, 2022
@lucacome lucacome added the chore Pull requests for routine tasks label Sep 29, 2022
coolbry95 added a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants