Skip to content

Conversation

@pasmant
Copy link
Contributor

@pasmant pasmant commented Aug 31, 2022

Configuration for security log only support filter field now.
To make backward compatibility the field in apdoslogconfs CRD doesnt remove.
The default values are no more needed in the CRD for format and max-message-size.
Content field values will be ignore, and warning will generate when creating new apdoslogconfs with content field.

@pasmant pasmant marked this pull request as draft August 31, 2022 08:31
@pasmant pasmant marked this pull request as ready for review August 31, 2022 08:32
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2022

Codecov Report

Merging #2991 (ebe0090) into main (17aad37) will increase coverage by 0.24%.
The diff coverage is 75.67%.

@@            Coverage Diff             @@
##             main    #2991      +/-   ##
==========================================
+ Coverage   52.29%   52.54%   +0.24%     
==========================================
  Files          58       58              
  Lines       16006    16069      +63     
==========================================
+ Hits         8371     8444      +73     
+ Misses       7356     7349       -7     
+ Partials      279      276       -3     
Impacted Files Coverage Δ
internal/k8s/controller.go 10.95% <0.00%> (-0.15%) ⬇️
...k8s/appprotectdos/app_protect_dos_configuration.go 94.56% <100.00%> (+0.31%) ⬆️
pkg/apis/dos/validation/dos.go 94.54% <100.00%> (+0.54%) ⬆️
...ternal/k8s/appprotect/app_protect_configuration.go 86.16% <0.00%> (-0.58%) ⬇️
internal/configs/configurator.go 37.06% <0.00%> (-0.32%) ⬇️
internal/configs/parsing_helpers.go 67.64% <0.00%> (ø)
internal/k8s/configuration.go 95.76% <0.00%> (+0.36%) ⬆️
internal/k8s/validation.go 93.81% <0.00%> (+0.49%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pasmant pasmant force-pushed the apdoslogconf_warning_content branch from 635f8c7 to 4fdbfb9 Compare September 7, 2022 13:50
@github-actions github-actions bot added the tests Pull requests that update tests label Sep 8, 2022
@github-actions github-actions bot added the docs label Sep 8, 2022
@nginx-bot nginx-bot removed the docs label Sep 8, 2022
@lucacome lucacome linked an issue Sep 20, 2022 that may be closed by this pull request
@lucacome lucacome requested review from a team, ciarams87, jjngx and shaun-nx September 23, 2022 01:01
@lucacome lucacome requested a review from a team September 23, 2022 16:46
@lucacome lucacome added this to the v2.4.0 milestone Sep 23, 2022
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Sep 23, 2022
@shaun-nx shaun-nx requested a review from lucacome September 29, 2022 15:51
@lucacome lucacome merged commit 28b4a63 into nginx:main Sep 29, 2022
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests/issues for documentation tests Pull requests that update tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nginx plus dos log invalid value for key: 'format': "user-defined"

7 participants