-
Notifications
You must be signed in to change notification settings - Fork 2k
Apdoslogconf will warning case format is not splunk #2991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2991 +/- ##
==========================================
+ Coverage 52.29% 52.54% +0.24%
==========================================
Files 58 58
Lines 16006 16069 +63
==========================================
+ Hits 8371 8444 +73
+ Misses 7356 7349 -7
+ Partials 279 276 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
635f8c7 to
4fdbfb9
Compare
jjngx
approved these changes
Sep 23, 2022
vepatel
approved these changes
Sep 23, 2022
lucacome
suggested changes
Sep 23, 2022
JTorreG
reviewed
Sep 29, 2022
JTorreG
approved these changes
Sep 29, 2022
Co-authored-by: Jcahilltorre <[email protected]>
lucacome
reviewed
Sep 29, 2022
internal/k8s/appprotectdos/app_protect_dos_configuration_test.go
Outdated
Show resolved
Hide resolved
lucacome
approved these changes
Sep 29, 2022
coolbry95
pushed a commit
to coolbry95/kubernetes-ingress
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration for security log only support filter field now.
To make backward compatibility the field in apdoslogconfs CRD doesnt remove.
The default values are no more needed in the CRD for format and max-message-size.
Content field values will be ignore, and warning will generate when creating new apdoslogconfs with content field.