Skip to content

Simplify grammar on HTTP Load Balancer #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Vleq
Copy link

@Vleq Vleq commented May 4, 2025

Update wording from beginning up through "Limit the Number of Connections". Break up long sentences and clarify ambiguous wording, using the linked pages on https://nginx.org/en/docs/ to disambiguate. (Improve readability of overall document from grade 17.6 to grade 14.6.)

Consistency changes throughout, favoring the wording most used in this document: Change all "load-balanc*" to "load balanc*" except in URLs. Change "parameter of" to "parameter to".

Remove gerunds from subheadings throughout.

Update wording from beginning up through "Limit the Number of Connections". Break up long sentences and clarify ambiguous wording, using the linked pages on https://nginx.org/en/docs/ to disambiguate. (Improve readability of overall document from grade 17.6 to grade 14.6.)

Consistency changes throughout, favoring the wording most used in this document: Change all "load-balanc*" to "load balanc*" except in URLs. Change "parameter of" to "parameter to". 

Remove gerunds from subheadings throughout.
@Vleq Vleq requested a review from a team as a code owner May 4, 2025 21:52
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-plus NGINX Plus (and NGINX Open Source in docs.ngninx.com) labels May 4, 2025
Copy link

github-actions bot commented May 4, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@Vleq
Copy link
Author

Vleq commented May 4, 2025

I have hereby read the F5 CLA and agree to its terms

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Vleq , I'll be happy to discuss your proposed contribution in more detail. I have more comments, but need time to review other pull requests.

@mjang mjang marked this pull request as draft May 7, 2025 03:33
@mjang
Copy link
Contributor

mjang commented May 19, 2025

Note: I had personally chatted with @Vleq during the conference about the proposed changes. @Vleq indicated that they were OK with my merging of my suggestions.

Beyond that, I wanted to give this one more review before making further changes / merging.

@ADubhlaoich ADubhlaoich marked this pull request as ready for review June 20, 2025 14:53
@ADubhlaoich ADubhlaoich requested review from a team and y82 June 20, 2025 14:54
@ADubhlaoich
Copy link
Contributor

Accepted Mike's suggestions and moved the PR out of draft state.

I have tagged the docs team widely and Yar specifically (as the TW for NGINX Plus) to get eyes on this PR.

Our apologies for the delay in reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nginx-plus NGINX Plus (and NGINX Open Source in docs.ngninx.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants