-
Notifications
You must be signed in to change notification settings - Fork 111
docs: Connect NGINX Agent to NGINX One using an explicit forward proxy #1025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview will be available once build job completes!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some suggestions. I gather we may replace this entire PR with a link to Squid docs.
content/nginx-one/agent/configure-instance-reporting/connect-using-squid.md
Outdated
Show resolved
Hide resolved
content/nginx-one/agent/configure-instance-reporting/connect-using-squid.md
Outdated
Show resolved
Hide resolved
content/nginx-one/agent/configure-instance-reporting/connect-using-squid.md
Outdated
Show resolved
Hide resolved
content/nginx-one/agent/configure-instance-reporting/connect-using-squid.md
Outdated
Show resolved
Hide resolved
content/nginx-one/agent/configure-instance-reporting/connect-using-squid.md
Outdated
Show resolved
Hide resolved
content/nginx-one/agent/configure-instance-reporting/connect-using-squid.md
Outdated
Show resolved
Hide resolved
content/nginx-one/agent/configure-instance-reporting/connect-using-squid.md
Outdated
Show resolved
Hide resolved
docs: clean up squid instructions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, a handful of small LOGAF nitpicks.
content/nginx-one/agent/configure-instance-reporting/connect-using-squid.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes needed. Approving to expedite merging.
Co-authored-by: Mike Jang <[email protected]>
docs: remove squid mentions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General question. I know port 3128 is used by Squid. Do all other (major) proxy services use the same port? (When I search through /etc/services, I see ports dedicated to other proxy services.)
So I think we should replace 3128
in the whole doc page with something generic like: <proxy port>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think we need to genericize the port number. Comment in place.
But since this is scheduled for release today, approving to expedite
Proposed changes
New doc explaining how to use an explicit forward proxy with Agent
Also:
NMS-46504
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩