Skip to content

Conversation

JTorreG
Copy link
Contributor

@JTorreG JTorreG commented Aug 25, 2025

Proposed changes

New doc explaining how to use an explicit forward proxy with Agent

Also:

  • Removed "reporting" from the Agent\Configure Instances

NMS-46504

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content.

@JTorreG JTorreG self-assigned this Aug 25, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-one Issues related to NGINX One Console labels Aug 25, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/1025/

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some suggestions. I gather we may replace this entire PR with a link to Squid docs.

@JTorreG JTorreG marked this pull request as ready for review August 27, 2025 09:21
@JTorreG JTorreG requested a review from a team as a code owner August 27, 2025 09:21
@JTorreG JTorreG requested review from mjang and y82 August 27, 2025 09:22
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, a handful of small LOGAF nitpicks.

@JTorreG JTorreG enabled auto-merge (squash) August 27, 2025 16:21
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes needed. Approving to expedite merging.

@JTorreG JTorreG changed the title docs: Connect NGINX Agent to NGINX One using squid proxy docs: Connect NGINX Agent to NGINX One using an explicit forward proxy Aug 28, 2025
@JTorreG JTorreG requested review from ADubhlaoich and mjang August 28, 2025 11:45
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question. I know port 3128 is used by Squid. Do all other (major) proxy services use the same port? (When I search through /etc/services, I see ports dedicated to other proxy services.)

So I think we should replace 3128 in the whole doc page with something generic like: <proxy port>

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think we need to genericize the port number. Comment in place.

But since this is scheduled for release today, approving to expedite

@JTorreG JTorreG merged commit e8fd863 into main Aug 28, 2025
10 checks passed
@JTorreG JTorreG deleted the agent/nms-46504 branch August 28, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nginx-one Issues related to NGINX One Console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants