Use Go Modules instead of Glock (fixes #338) #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this project was using glock to manage external go dependencies. As of go 1.11, go comes with builtin module support. Go Modules fully supersede glock functionality. As of go 1.16, either an environment variable or go modules are required for this project to build. This commit migrates the repository away from glock, and instead uses go modules. This gets rid of an unneeded dependency, and also allows the project to natively compile under go 1.16 (which requires `go.mod` by default). For go >= 1.13, compilation will "just work". To build under go 1.11 and go 1.12 one needs to set an environment variable 'GO111MODULE=on'. Since go <= 1.14 can be considered end of life, this change will likely not be impact any existing build scripts. This commit also updates the Travis Tests with more modern go versions, so that they can pass.
This was referenced Apr 2, 2021
jwilder
approved these changes
Apr 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this project was using glock to manage external go dependencies. As of go 1.11, go comes with builtin module support. Go Modules fully supersede glock functionality.
As of go 1.16, either an environment variable or go modules are required for this project to
build. As of go 1.17, go modules will be required.
This PR migrates the repository away from glock, and instead uses go modules.
This gets rid of an unneeded dependency, and also allows the project to natively compile under go 1.16.
For go >= 1.13, compilation will "just work". To build under go 1.11 and go 1.12 one needs to set an environment variable 'GO111MODULE=on'. Since go <= 1.14 can be considered end of life, this change will likely not impact any existing build scripts.
This commit also updates the Travis Tests with more modern go versions, so that they can pass.