Enable environment variables for attribute filters #1558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1558 +/- ##
=======================================
Coverage 81.74% 81.74%
=======================================
Files 207 207
Lines 23948 23948
Branches 3797 3797
=======================================
+ Hits 19576 19577 +1
Misses 3103 3103
+ Partials 1269 1268 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TimPansino
requested changes
Oct 28, 2025
newrelic/core/config.py
Outdated
Comment on lines
628
to
656
| def _environ_as_comma_separated_list(name, default=""): | ||
| result = [] | ||
| attributes = os.environ.get(name, default) | ||
|
|
||
| # Strip all whitespace and commas from the end of the string. | ||
| # That way, when we split a valid labels string by ',', the resulting | ||
| # list will contain no empty elements. | ||
|
|
||
| attributes = attributes.strip(", \t\n\r\f\v") | ||
|
|
||
| if not attributes: | ||
| return result | ||
|
|
||
| for attribute in attributes.split(","): | ||
| attribute = attribute.strip() | ||
|
|
||
| if attribute: | ||
| result.append(attribute) | ||
| else: | ||
| _logger.warning( | ||
| "Invalid configuration. Cannot parse: %r. Expected format 'attribute1, attribute2, attribute3'", | ||
| attributes, | ||
| ) | ||
| result = [] | ||
| break | ||
|
|
||
| return result | ||
|
|
||
|
|
There was a problem hiding this comment.
I believe you want _environ_as_set for this. We already used that for the logging attribute filter.
There was a problem hiding this comment.
For some reason, I thought these were comma delimited instead of space delimited. Changing that now to _environ_as_set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to use environment variables to enable/disable attributes as well as exclude/include filtering rules.
This can be useful for users running New Relic without an
*.inifile.The following have been added: