-
Couldn't load subscription status.
- Fork 131
Add support for partial granularity type #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop-hybrid-core-tracing
Are you sure you want to change the base?
Add support for partial granularity type #1532
Conversation
❌MegaLinter analysis: Error
Detailed Issues❌ PYTHON / ruff - 1 errorSee detailed reports in MegaLinter artifacts |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop-hybrid-core-tracing #1532 +/- ##
==============================================================
Coverage ? 31.75%
==============================================================
Files ? 207
Lines ? 24068
Branches ? 3817
==============================================================
Hits ? 7643
Misses ? 15871
Partials ? 554 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
831fa32 to
ca79220
Compare
303468c to
27573b4
Compare
7282263 to
b59cc63
Compare
4c9dd32 to
b962aba
Compare
0262e1a to
81943d0
Compare
e3f2de1 to
01b71d0
Compare
ddd7851 to
d3152cb
Compare
d3152cb to
eaa838d
Compare
01b71d0 to
48c4420
Compare
eaa838d to
849db5c
Compare
93685c7 to
6ea8705
Compare
79a37d6 to
f96dced
Compare
f96dced to
669f51e
Compare
* fix(aiomysql): avoid wrapping pooled connections multiple times * Move and rewrite regression test * Tweak implementation of fix --------- Co-authored-by: Tim Pansino <[email protected]>
Bumps the github_actions group with 4 updates: [actions/upload-artifact](https://github.com/actions/upload-artifact), [actions/download-artifact](https://github.com/actions/download-artifact), [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) and [github/codeql-action](https://github.com/github/codeql-action). Updates `actions/upload-artifact` from 4.6.2 to 5.0.0 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@ea165f8...330a01c) Updates `actions/download-artifact` from 5.0.0 to 6.0.0 - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@634f93c...018cc2c) Updates `astral-sh/setup-uv` from 7.1.1 to 7.1.2 - [Release notes](https://github.com/astral-sh/setup-uv/releases) - [Commits](astral-sh/setup-uv@2ddd2b9...8585678) Updates `github/codeql-action` from 4.30.9 to 4.31.0 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@16140ae...4e94bd1) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github_actions - dependency-name: actions/download-artifact dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github_actions - dependency-name: astral-sh/setup-uv dependency-version: 7.1.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github_actions - dependency-name: github/codeql-action dependency-version: 4.31.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github_actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Timothy Pansino <[email protected]>
f29653a to
edbfd79
Compare
|
|
||
| application_settings.attribute_filter = AttributeFilter(flatten_settings(application_settings)) | ||
|
|
||
| simplify_distributed_tracing_sampler_granularity_settings(application_settings) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that simplify_distributed_tracing_sampler_granularity_settings() should either
- be moved before the
attribute_filterapplication, but right afterapply_server_side_settings() - be removed all together and put the logic from that function in
apply_server_side_settings()(maybe after thecustom_insights_events.max_attribute_valueoverride?)

Overview
This adds support for the concept of partial granularity distributed traces. There are 3 types:
Add support for the following new configuration options: