Update lambda tracing examples #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 20, 2020 09:58
Updated dependencies and integration approach. Fleshed out SAM template to avoid manual configuration, and provide a best-practice example for functions with API Gateway integration.
Removed the section covering API Gateway on the AWS Console, as it's no longer necessary to make the example work.
jasonjkeller
requested changes
Aug 21, 2020
Contributor
jasonjkeller
left a comment
jasonjkeller
left a comment
There was a problem hiding this comment.
This looks great to me other than getting a couple of dependencies updated when the artifact is ready. I love that it greatly simplifies the proxy config.
examples/distributed-tracing-example/DTCalleeFunction/build.gradle
Outdated
Show resolved
Hide resolved
examples/distributed-tracing-example/DTCallerFunction/build.gradle
Outdated
Show resolved
Hide resolved
jasonjkeller
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root README and DT example code have been updated to use the new integration method.
The DT example's SAM template now includes the API Gateway config, and wires the two lambdas together, so that no further configuration is necessary. The template exports the "caller" Lambda's URL, for easy testing.