Standardize Node.js setup #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This standardizes the Node.js setup by: - Introducing an `.nvmrc` file specifying the version of Node.js to use when working with the repository. - Added `engines` to the `package.json` file. - Ensures the same version is used consistently in GitHub Actions workflows. - Updates the lock file format from version 2 to version 3.
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes the Node.js setup across the project by establishing consistent version requirements and updating CI/CD workflows to use Node.js 22.x LTS.
- Added
.nvmrcfile andenginesfield inpackage.jsonto specify Node.js 22.11.0 and npm 10.9.0 as minimum versions - Updated all GitHub Actions workflows to use Node.js version 22 instead of 20
- Standardized Node.js version usage across different brand plugin testing workflows
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Added engines field specifying minimum Node.js and npm versions |
| .nvmrc | Added file specifying Node.js major version 22 for development |
| .github/workflows/brand-plugin-test.yml | Updated all workflow jobs to use Node.js version 22 |
newfold-labs/workflows#84 will change the default value to `22`. Once all modules have an `.nvmrc` file, that will be used instead.
girish-lokapure
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This standardizes the Node.js setup by:
.nvmrcfile specifying the version of Node.js to use when working with the repository.enginesto thepackage.jsonfile.Since 22.x is the current LTS version of Node.js,
22.11.0is used as the minimum required version since it represents the release that transitioned the version from current to LTS status. The version ofnpmused (10.9.0) is the version bundled with22.11.0The GitHub Action workflows have been updated to ensure the desired version is used for testing.
This addresses PRESS0-2909 and PRESS0-2910.
Type of Change
Production
Development
Visual
Checklist
Further comments