Skip to content

fixes #143 Correct the logic for max retries in the handler and confi… #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025
Merged

fixes #143 Correct the logic for max retries in the handler and confi… #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lambda-invoker/src/main/java/com/networknt/aws/lambda/LambdaFunctionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,12 @@ public LambdaFunctionHandler() {
if(config.getMaxRetries() > 0) {
overrideConfig = overrideConfig.toBuilder()
.retryStrategy(DefaultRetryStrategy.standardStrategyBuilder()
.maxAttempts(config.getMaxRetries())
.build())
.maxAttempts(config.getMaxRetries() + 1) // +1 because the first attempt is not counted as a retry
.build())
.build();
} else {
overrideConfig = overrideConfig.toBuilder()
.retryStrategy(DefaultRetryStrategy.doNotRetry())
.build();
}

Expand Down
5 changes: 3 additions & 2 deletions lambda-invoker/src/main/resources/config/lambda-invoker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ endpointOverride: ${lambda-invoker.endpointOverride:}
apiCallTimeout: ${lambda-invoker.apiCallTimeout:60000}
# Api call attempt timeout in milliseconds. This sets the amount of time for each individual attempt.
apiCallAttemptTimeout: ${lambda-invoker.apiCallAttemptTimeout:20000}
# The maximum number of retries for the Lambda function invocation. Default is 3. Set to 0 to disable retries.
maxRetries: ${lambda-invoker.maxRetries:3}
# The maximum number of retries for the Lambda function invocation. Default is 2, which equals to 3 max attempts.
# Set to 0 to disable retries so that the Lambda function is invoked only once.
maxRetries: ${lambda-invoker.maxRetries:2}
# The maximum number of concurrent requests that can be made to Lambda. Default is 50.
maxConcurrency: ${lambda-invoker.maxConcurrency:50}
# The maximum number of pending acquires allowed. Default is 10000.
Expand Down