Skip to content

Conversation

stevehu
Copy link
Contributor

@stevehu stevehu commented Jun 3, 2025

No description provided.

@stevehu stevehu requested review from DiogoFKT and Copilot June 3, 2025 15:08
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for a new configuration option, maxRetries, to control the maximum number of retries for Lambda function invocations. The changes include:

  • Adding the maxRetries key with a default of 3 in the YAML configuration.
  • Introducing the maxRetries field, getter, and setter in the Java configuration class.
  • Enabling conditional retry strategy configuration in the Lambda function handler based on the maxRetries value.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
lambda-invoker/src/main/resources/config/lambda-invoker.yml Added maxRetries configuration entry with default and descriptive comment.
lambda-invoker/src/main/java/com/networknt/aws/lambda/LambdaInvokerConfig.java Added a constant, field, getter, and setter for maxRetries; updated configuration loading.
lambda-invoker/src/main/java/com/networknt/aws/lambda/LambdaFunctionHandler.java Added logic to conditionally apply the retry strategy based on maxRetries.

@stevehu stevehu merged commit b4b57b0 into master Jun 3, 2025
1 check passed
@stevehu stevehu deleted the issue141 branch June 3, 2025 15:11
Copy link
Contributor

@DiogoFKT DiogoFKT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants