-
Notifications
You must be signed in to change notification settings - Fork 0
Draft > Application: Draft 제목, 시리즈, URL을 임시저장 합니다. #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -2,20 +2,28 @@ | |||
|
||||
import nettee.blolet.article.domain.Draft; | ||||
import nettee.blolet.article.domain.DraftImage; | ||||
import nettee.blolet.article.domain.SeriesArticle; | ||||
import nettee.blolet.article.domain.sub.DraftStatus; | ||||
import nettee.blolet.article.readmodel.DraftReadModels.DraftDetail; | ||||
import nettee.blolet.article.readmodel.SeriesQueryModels.SeriesDetail; | ||||
|
||||
import java.util.Optional; | ||||
|
||||
public interface DraftCommandPort { | ||||
|
||||
Optional<DraftDetail> findById(String id); | ||||
Optional<DraftDetail> findDraftById(String id); | ||||
Optional<SeriesDetail> findSeriesById(String seriesId); | ||||
|
||||
boolean existsSeriesArticle(String draftId, String seriesId); | ||||
|
||||
Draft save(Draft draft); | ||||
DraftImage save(DraftImage draftImage); | ||||
SeriesArticle createSeriesArticle(String draftId, String seriesId, String articleId); | ||||
|
||||
Draft update(Draft draft); | ||||
|
||||
Draft updateTitle(String draftId, String title); | ||||
Draft updatePath(String draftId, String path); | ||||
SeriesArticle updateSeriesArticle(String draftId, String seriesId, String articleId); | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||
void updateDraftSeriesInfo(String draftId, String seriesId); | ||||
void updateStatus(String id, DraftStatus draftStatus); | ||||
|
||||
DraftImage save(DraftImage draftImage); | ||||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,21 +5,32 @@ | |
import nettee.blolet.article.application.usecase.DraftCreateUseCase; | ||
import nettee.blolet.article.application.usecase.DraftDeleteUseCase; | ||
import nettee.blolet.article.application.usecase.DraftImageCreateUseCase; | ||
import nettee.blolet.article.application.usecase.DraftPatchUseCase; | ||
import nettee.blolet.article.application.usecase.DraftUpdateUseCase; | ||
import nettee.blolet.article.domain.Draft; | ||
import nettee.blolet.article.domain.DraftImage; | ||
import nettee.blolet.article.domain.SeriesArticle; | ||
import nettee.blolet.article.domain.sub.DraftStatus; | ||
import nettee.blolet.blog.export.client.api.BlogClient; | ||
import nettee.upload.port.ImageStorage; | ||
import org.springframework.stereotype.Service; | ||
import org.springframework.web.multipart.MultipartFile; | ||
|
||
import static nettee.blolet.article.exception.DraftErrorCode.SERIES_ALREADY_REGISTERED; | ||
import static nettee.blolet.article.exception.DraftErrorCode.BLOG_MISMATCH; | ||
import static nettee.blolet.article.exception.DraftErrorCode.DRAFT_FORBIDDEN; | ||
import static nettee.blolet.article.exception.DraftErrorCode.DRAFT_NOT_FOUND; | ||
import static nettee.blolet.article.exception.DraftErrorCode.SERIES_NOT_FOUND; | ||
|
||
@Service | ||
@RequiredArgsConstructor | ||
public class DraftCommandService implements DraftCreateUseCase, DraftUpdateUseCase, DraftDeleteUseCase, DraftImageCreateUseCase { | ||
public class DraftCommandService implements | ||
DraftCreateUseCase, | ||
DraftUpdateUseCase, | ||
DraftDeleteUseCase, | ||
DraftImageCreateUseCase, | ||
DraftPatchUseCase { | ||
|
||
private final DraftCommandPort draftCommandPort; | ||
private final BlogClient blogClient; | ||
private final ImageStorage imageStorage; | ||
|
@@ -38,7 +49,7 @@ public Draft updateDraft(String userId, Draft draft) { | |
|
||
@Override | ||
public void deleteDraft(String userId, String draftId) { | ||
var blogId = draftCommandPort.findById(draftId) | ||
var blogId = draftCommandPort.findDraftById(draftId) | ||
.orElseThrow(DRAFT_NOT_FOUND::exception) | ||
.blogId(); | ||
validateOwnership(userId, blogId); | ||
|
@@ -48,7 +59,7 @@ public void deleteDraft(String userId, String draftId) { | |
|
||
@Override | ||
public DraftImage createDraftImage(String userId, String draftId, MultipartFile file, String targetName) { | ||
var blogId = draftCommandPort.findById(draftId) | ||
var blogId = draftCommandPort.findDraftById(draftId) | ||
.orElseThrow(DRAFT_NOT_FOUND::exception) | ||
.blogId(); | ||
validateOwnership(userId, blogId); | ||
|
@@ -64,6 +75,58 @@ public DraftImage createDraftImage(String userId, String draftId, MultipartFile | |
return draftCommandPort.save(draftImage); | ||
} | ||
|
||
@Override | ||
public Draft patchTitle(String userId, String draftId, String title) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎨 이 순서로 배치하는 게 유지보수하기에 좋습니다! 계속 추가하다 보면 자주 실수할 수 있는 영역이네요. class {
fields
public methods
private methods
} |
||
var draft = draftCommandPort.findDraftById(draftId) | ||
.orElseThrow(DRAFT_NOT_FOUND::exception); | ||
|
||
validateOwnership(userId, draft.blogId()); | ||
|
||
return draftCommandPort.updateTitle(draft.id(), title); | ||
} | ||
|
||
@Override | ||
public Draft patchPath(String userId, String draftId, String path) { | ||
var draft = draftCommandPort.findDraftById(draftId) | ||
.orElseThrow(DRAFT_NOT_FOUND::exception); | ||
|
||
validateOwnership(userId, draft.blogId()); | ||
|
||
return draftCommandPort.updatePath(draft.id(), path); | ||
} | ||
|
||
@Override | ||
public SeriesArticle registerSeriesArticle(String userId, String draftId, String seriesId, String articleId) { | ||
// 드래프트, 시리즈 조회 | ||
var draft = draftCommandPort.findDraftById(draftId) | ||
.orElseThrow(DRAFT_NOT_FOUND::exception); | ||
|
||
var series = draftCommandPort.findSeriesById(seriesId) | ||
.orElseThrow(SERIES_NOT_FOUND::exception); | ||
|
||
// 권한 검증 | ||
validateOwnership(userId, draft.blogId()); | ||
validateOwnership(userId, series.blogId()); | ||
|
||
// 블로그 동일 여부 확인 | ||
if (!draft.blogId().equals(series.blogId())) { | ||
throw BLOG_MISMATCH.exception(); | ||
} | ||
|
||
// 시리즈 존재 여부 확인 | ||
if (draftCommandPort.existsSeriesArticle(draftId, seriesId)) { | ||
throw SERIES_ALREADY_REGISTERED.exception(); | ||
} | ||
|
||
// 시리즈 등록 | ||
var seriesArticle = draftCommandPort.createSeriesArticle(draftId, seriesId, articleId); | ||
|
||
// 드래프트에 시리즈 정보 업데이트 | ||
draftCommandPort.updateDraftSeriesInfo(draftId, seriesId); | ||
|
||
return seriesArticle; | ||
} | ||
|
||
private void validateOwnership(String userId, String draftId) { | ||
var isOwner = blogClient.verifyOwnership(userId, draftId) | ||
.isOwner(); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package nettee.blolet.article.application.usecase; | ||
|
||
import nettee.blolet.article.domain.Draft; | ||
import nettee.blolet.article.domain.SeriesArticle; | ||
|
||
public interface DraftPatchUseCase { | ||
|
||
Draft patchTitle(String userId, String draftId, String title); | ||
|
||
Draft patchPath(String userId, String draftId, String path); | ||
|
||
SeriesArticle registerSeriesArticle(String userId, String draftId, String seriesId, String articleId); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The empty line and comment placement creates inconsistent formatting. Remove the blank line after the enum declaration or move the comment to align with other comment groupings.
Copilot uses AI. Check for mistakes.