Fix userWebpackConfig issue #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ouch, my bad. thank you. for future reference i'll bump the version numbers dont worry about bumping them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User encountered this in #156 (they closed the issue I guess because they were unstuck by a workaround but this PR has the actual fix in).
This commit here;
86332fb#diff-26b681bd4dac10f25d5293c7595c435bR34
inadvertedly made it mandatory to pass this config in, so users are getting the error as described in #156. This PR just makes that desctructuring a bit more defensive.
Cheers.