This repository was archived by the owner on Oct 10, 2022. It is now read-only.
Simplify options handling #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: chore
ehmicky
commented
Dec 15, 2020
| const hashFiles = async ( | ||
| dir, | ||
| configPath, | ||
| { concurrentHash, hashAlgorithm = 'sha1', assetType = 'file', statusCb, filter }, |
Contributor
Author
There was a problem hiding this comment.
concurrentHash and statusCb default values are assigned by the calling function.
ehmicky
commented
Dec 15, 2020
| statusCb: () => {}, | ||
| ...opts, | ||
| } | ||
| const hashFns = async (dir, { tmpDir, concurrentHash, hashAlgorithm = 'sha256', assetType = 'function', statusCb }) => { |
Contributor
Author
There was a problem hiding this comment.
concurrentHash and statusCb default values are assigned by the calling function.
ehmicky
commented
Dec 15, 2020
|
|
||
| // a parallel transform stream segment ctor that hashes fileObj's created by folder-walker | ||
| const hasherCtor = ({ concurrentHash, hashAlgorithm = 'sha1' }) => { | ||
| const hasherCtor = ({ concurrentHash, hashAlgorithm }) => { |
Contributor
Author
There was a problem hiding this comment.
hashAlgorithm default value is assigned by the calling function.
ehmicky
commented
Dec 15, 2020
|
|
||
| // Inject normalized file names into normalizedPath and assetType | ||
| const fileNormalizerCtor = ({ assetType = 'file' }) => | ||
| const fileNormalizerCtor = ({ assetType }) => |
Contributor
Author
There was a problem hiding this comment.
assetType default value is assigned by the calling function.
ehmicky
commented
Dec 15, 2020
| if (!statusCb || !assetType) throw new Error('Missing required options') | ||
| return objWriter((fileObj, _, cb) => { | ||
| // eslint-disable-next-line no-param-reassign | ||
| filesObj[fileObj.normalizedPath] = fileObj.hash |
Contributor
Author
There was a problem hiding this comment.
Ideally, we might want to return a copy, but in order to prevent any breaking, this keeps the fact that this function mutates arguments passed by its caller.
ehmicky
commented
Dec 15, 2020
|
|
||
| const { fnDir, configPath, statusCb, message: title } = opts | ||
|
|
||
| deployId: deployIdOpt = null, |
Contributor
Author
There was a problem hiding this comment.
Distinguish between opts.deploy (passed by user) and deploy.id (returned by API).
ehmicky
force-pushed
the
chore/improve-opts
branch
from
9e0c704 to
aa0ab56
Compare
erezrokah
approved these changes
Dec 16, 2020
ehmicky
force-pushed
the
chore/improve-opts
branch
2 times, most recently
from
fceb6f4 to
76a7ef7
Compare
ehmicky
force-pushed
the
chore/improve-opts
branch
from
76a7ef7 to
c422f0e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies options handling and makes the options available to each method more explicit.
It should not change behavior, but since this is a big refactoring, we should probably wait to release this after the holidays.