Skip to content

Conversation

@Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Nov 27, 2023

Contains two follow-ups to #6076, that were discovered while working on the Astro adapter.

  1. ntl serve should pick up routes from manifest.json
  2. __netlify-entrypoint.js is the wrong extension, it needs to be .mjs - see https://github.com/netlify/zip-it-and-ship-it/blame/f5fb309109408d25544fe34bdee77f917ff679e7/src/runtimes/node/utils/entry_file.ts#L150

@Skn0tt Skn0tt requested a review from a team as a code owner November 27, 2023 13:35
@Skn0tt Skn0tt requested a review from eduardoboucas November 27, 2023 13:35
@github-actions
Copy link

github-actions bot commented Nov 27, 2023

📊 Benchmark results

Comparing with 4027528

  • Dependency count: 1,396 (no change)
  • Package size: 404 MB (no change)
  • Number of ts-expect-error directives: 0 (no change)

@Skn0tt Skn0tt mentioned this pull request Nov 27, 2023
@Skn0tt Skn0tt enabled auto-merge (squash) November 28, 2023 06:47
@Skn0tt Skn0tt disabled auto-merge November 28, 2023 06:57
@Skn0tt Skn0tt merged commit af800af into main Nov 28, 2023
@Skn0tt Skn0tt deleted the serve-v2 branch November 28, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants