refactor: tests/integration/200.command.dev.test.cjs #5926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| t.is(await got(`https://localhost:${port}?ef=fetch`, options).text(), 'ORIGIN') | ||
| t.deepEqual(await got(`https://localhost:${port}/api/hello`, options).json(), { | ||
| const options = { | ||
| agent: new Agent({ rejectUnauthorized: false }), |
Check failure
Code scanning / CodeQL
Disabling certificate validation
Contributor
|
Not going to review yet as there are merge conflicts |
…t.cjs' of https://github.com/hereje/cli into refactor_test_esm/tests/integration/200.command.dev.test.cjs
…t.cjs' of https://github.com/hereje/cli into refactor_test_esm/tests/integration/200.command.dev.test.cjs
…t.cjs' of https://github.com/hereje/cli into refactor_test_esm/tests/integration/200.command.dev.test.cjs
…t.cjs' of https://github.com/hereje/cli into refactor_test_esm/tests/integration/200.command.dev.test.cjs
…t.cjs' of https://github.com/hereje/cli into refactor_test_esm/tests/integration/200.command.dev.test.cjs
Contributor
|
Hmm something weird happened with the diff here. |
sarahetter
approved these changes
Oct 24, 2023
hereje
deleted the
refactor_test_esm/tests/integration/200.command.dev.test.cjs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Related to: #5698
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)