Skip to content

Conversation

@ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Jan 15, 2022

We run Git hooks using Husky. We recently upgraded Husky. This is currently breaking installing this repository, in some specific cases.

This is because we currently rely on the husky binary indirectly provided by @netlify/eslint-config-node. In most cases, the binary will be symlinked to node_modules/.bin/, even though it's an indirect dependency. However, there are some cases where it does not. In those cases, an husky: not found error is thrown. For example, this is happening:

  • As part of the npm publish done in the release-please GitHub action
  • When installing this repository through GitHub (which is not recommended) like npm i github:netlify/cli#main

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

@ehmicky ehmicky added the type: bug code to address defects in shipped code label Jan 15, 2022
@github-actions
Copy link

📊 Benchmark results

Comparing with e281a90

Package size: 448 MB

(no change)

^  448 MB  448 MB  448 MB 
│   ┌──┐    ┌──┐    ┌──┐  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
│   |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴──>
    T-2     T-1      T    
Legend
  • T-2 (e281a90): 448 MB
  • T-1 (90449e5): 448 MB
  • T (current commit): 448 MB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Add to Kodiak auto merge queue type: bug code to address defects in shipped code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants