fix(functions): fixes an issue where the functions could not be served #3863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with ecfc91f Package size: 356 MB(no change) Legend
|
Member
eduardoboucas
left a comment
eduardoboucas
left a comment
There was a problem hiding this comment.
If I understand correctly, this is doing the same check twice: once in the registry when creating the NetlifyFunction instance, and again in the constructor of NetlifyFunction. Is that necessary?
Contributor
Author
|
@eduardoboucas yes you are absolutely right this wasn't the most elegant approach 😂 – I think I had to less coffee this morning (already updated) |
Contributor
Author
|
@eduardoboucas seems that some tests are failing need to investigate further maybe I broke something with the change |
lukasholzer
commented
Dec 20, 2021
|
|
||
| async scan(directories) { | ||
| async scan(relativeDirs) { | ||
| const directories = relativeDirs.filter(Boolean).map((dir) => (isAbsolute(dir) ? dir : join(this.projectRoot, dir))) |
Contributor
Author
There was a problem hiding this comment.
@erezrokah @ehmicky I think this is the fastet way to fix it -> Wondering if we can fix it on the long term inside the netlify config.
Contributor
There was a problem hiding this comment.
Yes, this should be addressed by netlify/build#3620.
eduardoboucas
approved these changes
Jan 7, 2022
erezrokah
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #3854
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)
