-
Notifications
You must be signed in to change notification settings - Fork 32
Fix ansible-lint violations and modernize Netdata ansible quck-start playbook #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Fixed 25 linting violations in ansible-quickstart - Added proper playbook.yml with FQCN modules - Converted task files to proper format - Added handlers and notify statements
…documentation - Redacted secrets from vars/main.yml (claim_token, claim_rooms) - Set reclaim back to false and dbengine_multihost_disk_space to 2048 - Added configurable installation options (netdata_channel, netdata_auto_updates) - Added PR_SUMMARY.md to .gitignore - Moved detailed ansible instructions to parent README with relative link - Updated PR summary with comprehensive change documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes the Netdata Ansible quickstart playbook by fixing ansible-lint violations and replacing deprecated installation methods with the current kickstart script approach. The changes ensure compliance with Ansible best practices while maintaining backward compatibility.
Key Changes:
- Fixed 25+ ansible-lint violations using FQCN and proper YAML formatting
- Replaced deprecated
netdata-claim.sh
with modernkickstart.sh
that handles both installation and claiming - Added proper playbook structure separating playbook-level elements from task files
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
vars/main.yml | Added new configuration options for installation channel and auto-updates |
templates/netdata.conf.j2 | Fixed template variable handling with proper Jinja2 syntax |
tasks/main.yml | Converted import_playbook to import_tasks with proper FQCN |
tasks/install.yml | Complete rewrite using modern kickstart script with integrated claiming |
tasks/configure.yml | Streamlined configuration task with proper FQCN and path handling |
tasks/claim.yml | Simplified to service verification since claiming moved to install |
playbook.yml | New main playbook file with proper structure and handlers |
README.md | Updated documentation with comprehensive usage instructions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
configuration-management/ansible-quickstart/tasks/configure.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Summary
There are several issues with the playbook at it is:
This PR fixes those issues.
Most importantly, it ensure the role remains functional as
my-netdata.io/kickstart.sh
is deprecated.Key Changes
Ansible-lint Compliance
ansible.builtin.*
)Modern Installation Approach
netdata-claim.sh
script with modernkickstart.sh
approachAdditional Installation Options
netdata_channel
: Choose 'stable' or 'nightly' installationnetdata_auto_updates
: Control automatic updates (default: false for automation)Improved Structure
playbook.yml
with playbook-level elementsUsage
Configuration Examples